Some minor cleanup to 'guess_worker_impl'#598
Draft
ahal wants to merge 2 commits intomozilla-releng:mainfrom
Draft
Some minor cleanup to 'guess_worker_impl'#598ahal wants to merge 2 commits intomozilla-releng:mainfrom
ahal wants to merge 2 commits intomozilla-releng:mainfrom
Conversation
The scriptworker-prov-v1 provisioner is already defined in constants.py, so no need to check for it explicitly.
bhearsum
approved these changes
Mar 13, 2023
Contributor
bhearsum
left a comment
bhearsum
left a comment
There was a problem hiding this comment.
Just to be clear: this wouldn't fix the issue we just had with langpacks (that resulted in https://phabricator.services.mozilla.com/D172475 as a workaround) - right? (This is purely just cleanup, that should have no impacts.)
Contributor
Author
Correct, well other than all the tests I broke >< |
Contributor
Author
|
Sigh, I guess that explicit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.